-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zsh support, remove extra output on macOS #4
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! I'm asking around to find someone to verify this pull request for me since I can't afford a Mac lol. I'll get back to you soon hopefully! Er, one more thing, the thing that checks the shell and whatnot does seem to add a bit of extra bulk, I might try to trim that down a teeny bit. I guess I ought to learn how to use zsh first since it's the hot new thing. |
Alright, thanks for the consideration!
Yup, Again, if you've got any ideas on how to trim some of that code down, I'd really appreciate it. I tried Googling a fair bit and there doesn't seem to be many good options that check the user's shell. For example, |
Also, I think that the only reason that any of this is necessary is because |
News? |
Tried your merge on ubuntu, got:
|
Haven't worked on this recently, but I'd appreciate any suggestions on how to improve it!
Yeah, that's odd. My pr definitely shouldn't be merged in its current state. There are likely compatibility issues scattered throughout. If anyone wants to give zsh support a try, feel free to do so! I might give it another shot myself later when I have some spare time. |
This pull-request adds zsh support by:
MELEE_DIR
directory; and,eval
to run the play command.This PR also contains a second, smaller commit that removes the
(eval):disown:1: no current job
message when the script is run on macOS.I'm quite a novice at scripting, so please tell me if anything looks wrong. I would greatly appreciate feedback. Specifically, the case block in the
current_shell()
is likely unnecessary, but I wasn't sure how I could strip a potential leading dash fromps
's output.